-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should landcover be ordered by z_order? #53
Comments
Something small under a big field comes to mind, although I'm not 100% certain what landcover would be underneath. |
The most common case is probably underground parking. Not sure what else this is relevant for? |
Piers are another example, see #330. |
See also #685. |
Are there any other examples for which this is relevant? |
Similar to the examples in #685 are subway stations in Munich: |
Here's another example: Big buildings above a large underground railway platform in Chicago: |
In fact I think it's an example of #688. Neither buildings nor railway platforms are rendered by the landcover layer. |
Given that we haven't seen any usecase for ordering landcover by z_order in 2 years time, I will close this. Ordering of railway platforms etc. will still be considered, but these are not landcover. |
Now I look at this issue again, I see that my statement does not correspond to my action. I thought the current situation was that z_order (or layer) is not taken into account, but in fact it is. I still think it would be better not to take it into account, so the correct action, I think, would be to remove the layer column from the ORDER BY. |
Low zoom ordering has been removed in #2740, is it enough for us and the issue can be closed or we want to remove more of it? |
I think we also want to remove the z_order from the regular landuse query. |
At the moment the query orders by both z_order and way_area. Ordering by area makes sure small polygons end up on top (where there's no holes in a larger polygon). I guess z_order will help if the features are on separate layers, since there's no fine control over landcover ordering required.
But is this necessary? Are overlapping features with different z_orders - and the larger one on top - either common or wanted?
The text was updated successfully, but these errors were encountered: