Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leisure=track should not be an area #574

Closed
matthijsmelissen opened this issue May 26, 2014 · 10 comments
Closed

Leisure=track should not be an area #574

matthijsmelissen opened this issue May 26, 2014 · 10 comments

Comments

@matthijsmelissen
Copy link
Collaborator

Leisure=track is currently rendered as area. However, it should be rendered as way.

This requires a change to the osm2pgsql style sheet.

See also https://trac.openstreetmap.org/ticket/2339

@matthijsmelissen matthijsmelissen added this to the 3.x - Needs upgrade to mapnik or openstreetmap-carto.style milestone May 26, 2014
@pnorman
Copy link
Collaborator

pnorman commented May 27, 2014

This requires a change to the osm2pgsql style sheet.

No it doesn't, nor would changing leisure to linear be a viable option. You can turn POLYGONs into LINESTRINGs.

@matthijsmelissen matthijsmelissen removed this from the 3.x - Needs upgrade to mapnik or openstreetmap-carto.style milestone Jul 20, 2014
@matthijsmelissen matthijsmelissen self-assigned this Jul 20, 2014
@matthijsmelissen matthijsmelissen removed their assignment Dec 8, 2014
@kocio-pl
Copy link
Collaborator

According to Wiki it should be rendered as area if there is also area=yes. However I'm not able to prepare PR resolving this issue, because I don't know what changes should be done exactly.

@matthijsmelissen
Copy link
Collaborator Author

This could be fixed by osm2pgsql-dev/osm2pgsql#346. If osm2pgsql doesn't accept ths change we could also create our own .lua file.

However, I'm still not fully sure what the desired behaviour is?

@kocio-pl
Copy link
Collaborator

For me by default it should be rendered as a line and as an area when a closed line is tagged with area=yes.

@polarbearing
Copy link
Contributor

... and as an area when it is a multipolygon.

@SomeoneElseOSM
Copy link
Contributor

@math1985 as Lonvia said in osm2pgsql-dev/osm2pgsql#346 (comment) if you're going to move to lua processing in OSM's "standard" style, surely you're going to use custom lua processing for that style, and not whatever standard/example "style.lua" is included with osm2pgsql?

There are places where using lua instead of SQL to do processing would vastly simplify the resulting SQL that needs to be written - I think it would be very beneficial to make use of that capability where appropriate.

(naturally "moving to lua processing" assumes that the drawbacks of that, such as database reloads if e.g. tag consolidation is done have been considered and the change is thought to be beneficial overall - that's a much larger issue than just one style change)

@matthijsmelissen
Copy link
Collaborator Author

@math1985 as Lonvia said in osm2pgsql-dev/osm2pgsql#346 (comment) if you're going to move to lua processing in OSM's "standard" style, surely you're going to use custom lua processing for that style, and not whatever standard/example "style.lua" is included with osm2pgsql?

I haven't thought of that yet really. The process of moving to hstore is going extremely slow (it's already on the agenda for multiple years), so at the moment I'm inclined towards rolling out a solution that is as simple as possible first, so at least we can get something done, rather than keep discussing without ever accomplishing something.

Also, some of our users (for example @gravitystorm himself) use a single PostGIS database for multiple rendering styles, which also suggests not making to complex / style-specific decisions in the lua file.

@kocio-pl
Copy link
Collaborator

Related to #2238 (lua branch).

@HolgerJeromin
Copy link
Contributor

I think this should be renamed and reopened. Or we need a new issue.

https://www.openstreetmap.org/way/144179903 is not rendered on master and lua, so we have no style definition.

@imagico
Copy link
Collaborator

imagico commented May 11, 2017

Opened new issue #2632.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants