Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneway arrows of nearby roads covering each other can be misleading #706

Open
matkoniecz opened this issue Jul 7, 2014 · 10 comments
Open

Comments

@matkoniecz
Copy link
Contributor

http://www.openstreetmap.org/?mlat=50.05523&mlon=19.94447#map=18/50.05523/19.94447

przechwytywanie

Residential is not oneway, private service roads rendered below are.

Related to #597 #681 #245

Fixing #284 would probably also fix most occurrences of this bug.

@matthijsmelissen
Copy link
Collaborator

There are performance problems involved with solving this. We could render oneway arrows immediately on top of the road it belongs to, but it would imply having three times as much road rules in the xml (for oneway=yes, -1 and no).

@pnorman
Copy link
Collaborator

pnorman commented Jul 9, 2014

oneway=yes, -1 and no

Given the sparsity of oneway values other than yes, we could normalize all oneway values to null or yes by reversing -1 and turning no into null without any real performance issues. This would also help make the MSS simpler by removing the -1 case

@matthijsmelissen
Copy link
Collaborator

Still it would mean duplicating the number of rules for roads.

@pnorman
Copy link
Collaborator

pnorman commented Aug 19, 2014

Is the number of rules a significant performance issue? I've found the number of layers generally more significant. I would like to take a look at reversing oneway=-1 ways to only get oneway=yes or oneway IS NULL out of the layers

@matkoniecz
Copy link
Contributor Author

from #953 http://www.openstreetmap.org/#map=17/59.30845/15.41528

motorway_link arrow renders over the secondary road

przechwytywanie

(fixing #284 would fix also this case)

@matkoniecz
Copy link
Contributor Author

And sometimes results are really misleading - see http://www.openstreetmap.org/#map=19/50.07165/19.94518

selection_001
selection_002

@cody-somerville
Copy link

Slightly different manifestation of this issue. Example where oneway arrows get rendered outside of the typical visual context of a road entirely.

underground_oneways_arrow_rendering

The arrows jump around at different zoom levels which without the visual context of the parent road element, due to being underground, is especially confusing until you realize what's happening as they seem like they're meaningfully pointing and moving to draw attention as you zoom.

(I notice the label "PATH" (by The Archer) for an underground walkway is also rendering seemingly orphaned. Similar or different issue?)

Also, would it make sense to tweak the issue title? I initially thought this was going to be related to roads tagged covered=yes such as building passages.

@matkoniecz
Copy link
Contributor Author

Also, would it make sense to tweak the issue title? I initially thought this was going to be related to roads tagged covered=yes such as building passages.

Can you propose a better one?

@imagico
Copy link
Collaborator

imagico commented Jun 20, 2023

@cody-somerville - that is a different problem for which we already have #529.

@imagico imagico changed the title oneway arrows from covered road are appearing oneway arrows of nearby roads covering each other can be misleading Jun 20, 2023
@imagico
Copy link
Collaborator

imagico commented Aug 31, 2024

By the way this is also closely related to #2213 and #4401.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants