Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landuse=basin with basin=detention #709

Closed
merkato opened this issue Jul 10, 2014 · 16 comments
Closed

landuse=basin with basin=detention #709

merkato opened this issue Jul 10, 2014 · 16 comments

Comments

@merkato
Copy link

merkato commented Jul 10, 2014

As in http://wiki.openstreetmap.org/wiki/Tag:landuse%3Dbasin landuse=basin + basin=detention should be used for tagging of dry basins for stormwater.

Proposal for rendering:
polder_bukow_propozycja_small

@matkoniecz
Copy link
Contributor

basin key is currently not in the dabase (see https://github.com/gravitystorm/openstreetmap-carto/blob/master/openstreetmap-carto.style ), so it is unlikely to be done in near future.

@pnorman pnorman added this to the 3.x - Needs upgrade to mapnik or openstreetmap-carto.style milestone Jul 10, 2014
@matthijsmelissen
Copy link
Collaborator

@matthijsmelissen matthijsmelissen self-assigned this Jul 20, 2014
@pnorman
Copy link
Collaborator

pnorman commented Aug 12, 2014

Looking at a couple semi randomly selected landuse=basin areas, I wonder if we should be using a similar rendering for all basins.

@claysmalley
Copy link

Under landuse=basin:

  • basin=retention should be filled with blue, like a lake or a reservoir
  • basin=detention and basin=infiltration should be displayed like a wetland, with little blue markings peppered all over but not covering what's underneath

As it is right now, all basin=* is rendered the former way, and we'd just have to be more specific about what types of basins render which way. This looks like a pretty easy fix.

@matthijsmelissen
Copy link
Collaborator

This looks like a pretty easy fix.

So feel free to propose a pull request :)

Sorry for the delay, but we have hundreds of things that are all "easy fixes"...

@claysmalley
Copy link

Thanks for the reply!

I've actually been working on that since last night. The code seems straightforward enough but I'm having a hell of a time following the vague, prior-knowledge-required installation instructions. It'd be really nice if someone could help me get this thing up and running so I can test what I'm doing.

@pnorman
Copy link
Collaborator

pnorman commented Dec 18, 2014

http://switch2osm.org/loading-osm-data/ for loading the data. For tilemill, https://hackpad.com/TileMill-I6rxRVszKMv is as far as I got

@matkoniecz
Copy link
Contributor

@claysmalley See also #657 (comment)

@matkoniecz
Copy link
Contributor

@claysmalley Note also that basin key is currently not in the dabase (see https://github.com/gravitystorm/openstreetmap-carto/blob/master/openstreetmap-carto.style ), so merging implementation for this requires reloading entire database.

@matkoniecz
Copy link
Contributor

If that is still something that should be fixed - is anybody aware about OSM elements that would be a good examples of situation?

@jragusa
Copy link
Contributor

jragusa commented May 13, 2018

According to the wiki definition and since #3104, we can render the subtag basin as intermittent water body as figured in the first post.

@matkoniecz
Copy link
Contributor

@jragusa Can you provide any example of OSM element (way/relation)?

@jragusa
Copy link
Contributor

jragusa commented May 14, 2018

Initially, I thought it was only related to storm events and hence to some countries (U.S.) but actually we also find this feature in Europe. They are built to store water during important rainfall and hence prevent large river flooding. They are also frequently found along major highways.

An example here near Annecy (https://www.openstreetmap.org/#map=18/45.92946/6.12063) where you can find 2 basins with the correct tags (https://www.openstreetmap.org/way/529090226 and https://www.openstreetmap.org/way/529090223).

Look at the aerial photograph to compare: https://www.geoportail.gouv.fr/carte?c=6.121392731642797,45.929393524870136&z=18&l0=ORTHOIMAGERY.ORTHOPHOTOS::GEOPORTAIL:OGC:WMTS(1)&l1=GEOGRAPHICALGRIDSYSTEMS.MAPS::GEOPORTAIL:OGC:WMTS(0)&permalink=yes

The upper one contains some water while the lower one is empty

@jragusa
Copy link
Contributor

jragusa commented May 30, 2018

@matkoniecz
same location with intermittent pattern:
https://www.openstreetmap.org/#map=18/45.92935/6.12104
basin_retention

@jragusa
Copy link
Contributor

jragusa commented Nov 6, 2018

@matkoniecz and @kocio-pl Are you agree to apply intermittent water body pattern to the basin=retention, basin=detention and basin=infiltration tags ?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Nov 6, 2018

Reading Wikipedia articles and short description on OSM wiki I understand that basin=retention is called wet pond, because it does not loose water, so I would leave it as it is. But basin=detention and basin=infiltration are meant to loose water over time, so it makes sense to me to render them as intermittent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants