Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Hotkeys work only with English language is active #283

Open
bsekachev opened this issue Jul 3, 2020 · 0 comments
Open

[BUG] Hotkeys work only with English language is active #283

bsekachev opened this issue Jul 3, 2020 · 0 comments

Comments

@bsekachev
Copy link

Describe the bug

Hi, thanks for this great React library. Actually I am not sure whether it is a bug or a feature request.
We use the library in our project and have some issues related with system language.
When another language is active (not the language shortcuts described), shortcuts don't work.
I found similar issue here #184 but it is already closed.

Offered workaround is to create custom keycodes or define combinations for each used language.
The problem is that in our case the tool is international (not only Russian or English) and defining custom keycodes for each possible language is a huge overhead. Using of the property keycode instead of key would be much more preferable.

Another related issue that looks more like a bug is that when CAPSLOCK is activated, hotkeys also don't work.

I would ask you if there are plans to support the feature, or maybe it worked in previous release, or maybe you can provide good advice. I can say that early we used mousetrap and it worked fine here.

How are you using react hotkeys components? (HotKeys, GlobalHotKeys, IgnoreKeys etc)
HotKeys, GlobalHotKeys

Expected behavior
Hotkeys work when any system language is active

Platform (please complete the following information):

  • Version of react-hotkeys: 2.0.0
  • Browser [e.g. chrome, safari]: Chrome, Firefox
  • OS: [e.g. iOS]: Win, Ubuntu

Are you willing and able to create a PR request to fix this issue?
I suppose I do not have enough expertise for the feature

Include the smallest log that includes your issue:

Set logging to verbose (you'll need the development build if its possible):

import { configure } from 'react-hotkeys';

configure({
  logLevel: 'verbose'
})

What Configuration options are you using?

configure({
  //options
})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant