-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AndroidX support #552
Comments
Please refer to https://developer.android.com/jetpack/androidx/migrate on how to use AndroidX with libraries that do not yet use the new imports. Keeping this open to track switching to AndroidX. |
I've been having an issue with AndroidX whereby I get a NoClassDefFoundError when the find methods code walks down the inheritance tree. A quick and dirty fix would be to filter for androidx packages in the moveToSuperclass() method. I've created a pull request for this, and it'd make sense from a performance perspective too. |
AndroidX has been out for over a year now. Is there any update on this? This is the last non-AndroidX library in my project's external dependencies. |
https://github.com/greenrobot/EventBus/releases/tag/V3.2.0 And the remaining code that uses the legacy Android Support Library APIs should not be used, anyhow (e.g. ErrorDialogManager). @cckroets I use the latest release in an AndroidX project without issues. What is preventing you from doing so? |
It requires enabling Jetifier which adds time to the build. It will analyze and re-write every external dependency to use AndroidX, which can be expensive for large projects. |
Any plan to support AndroidX? Why the pull request is being ignored #627 ? We want to get rid of Jetifier which slows down builds, so is there a chance that EventBus will get migrated or should we rather remove it from our dependencies? |
In order to improve our build times (which are a pain point in our codebase), we're currently pushing to remove jetifier from our builds. This change has had two years to bake, and apart from the build speed wins we're excited to simplify our system by eliminating this legacy concern. We don't directly rely on EventBus, but it is a transitive dependency used by a third party library we use. Unfortunately, jetifier cannot be selectively turned on and off for each individual project: it's either all or nothing. So EventBus is blocking this goal for us. |
Then please release 3.3 removing those classed. It's high time! |
Anybody there? |
Sorry, busy with other things. Using AndroidX would require making EventBus into an Android library (AAR), have not had time to look into resolving this (e.g. there still should be a plain Java version). |
But should it really be available as plain Java? I know that it would be nice, but does the library have substantial amount of non-android users? |
I do use this libary in my shared API and business logic module between my JVM Discord Bot and Android App. So this library should be kept compatible for plain Java in my opinion. |
maybe would be better to just remove all android dependencies, and make this library a pure java library. no need for jetifier or androidx then. what is the plan for this? |
We decided to remove EventBus from our project. |
Any update about this issue? Like others developers, this is the last legacy dependencies in our project. |
The recommended solution for that right now is Kotlin Coroutines but you have to learn a whole new thing just to use that. Not to mention Google Guava has EventBus functionality although marked as beta. |
@sarbyn @Amrsatrio new version is on its way. I made a pull request with the changes, now new code is being polished and tested by @greenrobot-team . will be released soon I hope :) |
@greenrobot-team When will the separate android event bus artifact without support libraries be available? I see it's waiting for a review since July: #670 |
Have been patiently waited for the migration for long long time, hopefully it could be done soon. Thanks for all your effort! |
It looks like Google plans to get rid of Jetifier in the future AGP release: https://issuetracker.google.com/issues/141128458#comment13 |
A preview release that resolves this issue is now available: If you want to help test this, you need to add the OSSRH snapshot repository in your allprojects {
repositories {
maven { url = uri("https://oss.sonatype.org/content/repositories/snapshots/") }
}
} |
This is now resolved as part of the |
Now that Android Studio 3.2.0 and
androidx
1.0.0 libraries have been released, is there a plan to migrate toandroidx
? Google has said there won't be any more feature releases under theandroid.support
packaging.The text was updated successfully, but these errors were encountered: