Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python tooling & justfile #1

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Add Python tooling & justfile #1

wants to merge 4 commits into from

Conversation

gregorni
Copy link
Owner

@gregorni gregorni commented Sep 26, 2023 •
edited
Loading

@sonnyp @TheEvilSkeleton What do you think of this? Is this a good selection of tools, are there any options missing, should more tools be added?

@gregorni gregorni changed the base branch from main to dev September 26, 2023 19:26
@gregorni gregorni changed the base branch from dev to main September 26, 2023 19:27
TheEvilSkeleton
TheEvilSkeleton reviewed Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@TheEvilSkeleton TheEvilSkeleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be in another commit. Other than that, you have my approval

src/main.py Outdated Show resolved Hide resolved
src/main.py Outdated Show resolved Hide resolved
@gregorni
Copy link
Owner Author

Alright, good idea.

If we want, we can always add more linters later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheEvilSkeleton TheEvilSkeleton Awaiting requested review from TheEvilSkeleton

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregorni @TheEvilSkeleton