-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Environment Variables #37
Comments
I'm not sure about this. There are just SO many options. Maybe I can add for some of the most common if specifically requested, but as is it isn't too hard to make a config file (and most implementations probably don't need manual config file edit anyway). |
Hi, Config files need persistent storage, env variables do not, and can be used in the same measure between container hosts, kubernetes or otherwise. The data storage for said container needing a persistent volume is an argument for relying on a config file, as is "easiness", however a PV should be used for data, not configs, and the easiness is something that is moot when it comes to the difference between the two methods. Perhaps start with the common ones - Just a suggestion :-) |
I think it's a great idea, to add the environment variables, to facilitate automatic configuration, without intervention. |
I'll throw my 2 bits in here, that for some things it could be very useful. The ports, username/password from a secrets file, or LDAPS/OAUTH settings would all work beautifully in a .env file or variables. |
Overhauling the configuration methodology is definitely on my todo list. When I will actually have time to make that happen is a different question. |
Hi,
Would be useful to have common (or all) options that can be setup in the configuration files, to be available as environment variables on the container.
Thanks!
The text was updated successfully, but these errors were encountered: