Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Environment Variables #37

Open
boomam opened this issue Dec 27, 2023 · 5 comments
Open

[FEATURE REQUEST] Environment Variables #37

boomam opened this issue Dec 27, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@boomam
Copy link

boomam commented Dec 27, 2023

Hi,
Would be useful to have common (or all) options that can be setup in the configuration files, to be available as environment variables on the container.

Thanks!

@gregtwallace
Copy link
Owner

I'm not sure about this. There are just SO many options. Maybe I can add for some of the most common if specifically requested, but as is it isn't too hard to make a config file (and most implementations probably don't need manual config file edit anyway).

@boomam
Copy link
Author

boomam commented Dec 28, 2023

Hi,
Think of it this way - config files are not a recommended practice for anything "cloud native" - meaning a modern method of container usage.

Config files need persistent storage, env variables do not, and can be used in the same measure between container hosts, kubernetes or otherwise.

The data storage for said container needing a persistent volume is an argument for relying on a config file, as is "easiness", however a PV should be used for data, not configs, and the easiness is something that is moot when it comes to the difference between the two methods.
Leaving just an advantage for overall configuration through code (docker-compose, helm, etc.).

Perhaps start with the common ones -
Logging, config of a DNS provider (like Cloudflare"s keys for example), ports, ect.
Build from there over time as it gets requested.

Just a suggestion :-)

@CygnusHyoga
Copy link

I think it's a great idea, to add the environment variables, to facilitate automatic configuration, without intervention.

@gregtwallace gregtwallace added the enhancement New feature or request label Apr 24, 2024
@mwsmith824
Copy link

I'll throw my 2 bits in here, that for some things it could be very useful. The ports, username/password from a secrets file, or LDAPS/OAUTH settings would all work beautifully in a .env file or variables.

@gregtwallace
Copy link
Owner

Overhauling the configuration methodology is definitely on my todo list. When I will actually have time to make that happen is a different question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants