Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you have a plan to update the package and to add it to the registry? #11

Open
likanzhan opened this issue Apr 27, 2022 · 8 comments
Open

Comments

@likanzhan
Copy link
Contributor

likanzhan commented Apr 27, 2022

It is a package that I looked for a long time. It is very helpful to deal with eyelink data with Julia. Thanks.

@grero
Copy link
Owner

grero commented Apr 27, 2022

I'm glad you find it useful. I have been using it for a couple of years to load data from various experiments, and I guess I hadn't really considered that it would be used by anyone else. As a result, I haven't been too careful in how the data is presented to user altering being loaded. If you have any suggestions on how to improve usability, I'd be happy to make changes.

@likanzhan
Copy link
Contributor Author

likanzhan commented Apr 27, 2022

Thanks, you have mentioned one thing what I'm thinking.
(1) Add some show methods would be much better.
(2) Also is it possible to add the edfapi locally, so that the package would be more portable ? (i.e., we do not need to install the Eyelink api)?
(3) Could you also export the blink events information? I think this information is important, especially if we want to compare the obtained eye tracking data with EEG data.

@grero
Copy link
Owner

grero commented Apr 28, 2022

Regarding point (2), since SR-Research as far as I know has not released a description of the EDF file format, it's going to be very hard to bypass the C-API. It would mean rewriting all the low-level functions in Julia.

@grero
Copy link
Owner

grero commented Apr 28, 2022

Regarding (1), I've added some barebones show methods here #13

@grero
Copy link
Owner

grero commented Apr 28, 2022

I just merged #14 which adds parsing of start/end blink events.

@likanzhan
Copy link
Contributor Author

likanzhan commented May 2, 2022

Thank you very much.

Do you think is it better if the functions are split into two levels:

(1) some low levels functions that simply mimic the c functions, which can be used and extended by high level functions.

(2) some high level functions that can be used and extended by the users.

Thanks

@grero
Copy link
Owner

grero commented May 4, 2022

I think this is a good idea. I'm not really sure what low-level functions would be useful, though? I find that most of the time I just want to get edf data into a julia session, in which case just running Eyelink.load("somefile.edf") does the trick.
Do you have any suggestions of what low-level functions might be useful to access directly?

@likanzhan
Copy link
Contributor Author

I think it depends on whether you are planning to register it as a package for others to use. If it is, I think it is better to include all the functions defined in EDF Access C API user manual. I am no expert on either C, Julia, or EyeLink. And I mainly use the so called visual world paradigm in eye-tracking technique. And I find all the functions are potentially useful. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants