Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of deprecated WarPluginConvention #266

Open
donat opened this issue Sep 19, 2022 · 2 comments
Open

Remove usage of deprecated WarPluginConvention #266

donat opened this issue Sep 19, 2022 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@donat
Copy link

donat commented Sep 19, 2022

The property read here comes from the deprecatedWarPluginConvention

gretty/libs/gretty/src/main/groovy/org/akhikhl/gretty/ProjectUtils.groovy

Line 232 in caea8a9

project.hasProperty('webAppDir') ? project.webAppDir : new File(project.projectDir, 'src/main/webapp')

We'll soon add deprecation nagging for all usages, and later remove it. Work is tracked here (ZenHub extension needed).
@f4lco
Copy link
Collaborator

f4lco commented Sep 23, 2022

Thank you for brining this up, supposedly removing the usage is trivial.

@f4lco f4lco added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 23, 2022
@donat
Copy link
Author

donat commented Sep 24, 2022 •
edited
Loading

You can get the properties directly from the War task:
https://docs.gradle.org/nightly/userguide/upgrading_version_7.html#war_convention_deprecation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@donat @f4lco