Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescaling time for task 1: ideal mass-spring #7

Open
SPronav opened this issue Jul 26, 2024 · 0 comments
Open

Rescaling time for task 1: ideal mass-spring #7

SPronav opened this issue Jul 26, 2024 · 0 comments

Comments

@SPronav
Copy link

SPronav commented Jul 26, 2024

Hi Sam,

I'm Srinivasa Pranav, a PhD student at CMU. We were interesting in recreating your experiments and comparing our method to HNNs.

In analyze-spring.ipynb, we had a hard time understanding why time is rescaled in the numerical integration using RK45 (from scipy's solve_ivp). This is in the integrate_models function under the "Quantitative Analysis" section:

# rescale time to compensate for noise effects, as described in appendix
t_span[1] *= 1 + .9*noise_std
t_eval *= 1 + .9*noise_std

This step has a significant impact on the results. We were unable to find information in the paper's appendix, so we hope you could guide us to a reference.
Also, since other experiments/tasks don't rescale time, we were interested to know why Task 1 requires it while other tasks do not.

Besides this, we really appreciate your efforts in neatly organizing your code and making it easy to understand.
Thank you!
Pranav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant