Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking creates one cent output #311

Closed
tomasbrod opened this issue May 19, 2017 · 5 comments
Closed

Staking creates one cent output #311

tomasbrod opened this issue May 19, 2017 · 5 comments

Comments

@tomasbrod
Copy link
Member

Coin stake seems to always produce one cent output in addition to the normal output.

  • Why?
  • Is it needed?
  • Why not split it to half?
  • Why split it at all?

I merged this output with the normal output and testing it in testnet. So far it seems to work. Other proof of stake coins seem to split the stake output in half. Gridcoin changed that code (src/wallt.cpp/CreateCoinStake) with a comment:

Place all but one cent in the first output so stakes dont get smaller - Note: the .01 GRC will be
consolidated on any outbound transaction so this should NOT become a nuisance anymore.

@tomasbrod
Copy link
Member Author

When a stake transaction is successfully created, it it very flexible. More inputs can be added to receive interest on all of them. This can be used to harvest interest on all coins at once.
The output is flexible too. One can choose to have only one output with all the input funds and reward combined. Or split to two or more equal parts. Or create separate outputs for stake, fees, interest and research. Splitting output may be beneficial when you want to stake a lot of blocks (16 hour maturity). Adding coins from other addresses is a privacy concern.

I propose this to be configurable.

  • stake input options
    • only one input
    • all from the same address
    • all coins in wallet except reserve balance
  • stake output options
    • all in one
    • split to configured size
    • split to parts (in,fees,interest,research)
    • split to configured size and reward separate

@iFoggz
Copy link
Member

iFoggz commented May 22, 2017

This would explain a lot. Thanks for the info!
I run 10 grc addresses in my wallet dedicated to staking (which 5 are in use) with coins split over them. It allows me to stake more frequently. I've noticed other high grc balance users do the same. For example I staked 3 blocks within ~12 hours as there were mature coins in other wallets allowing my weight to still be reasonable. cheers

@tomasbrod
Copy link
Member Author

@Foggyx420 You can do the same with single wallets. Just create more addresses and send money there. Use coin control features to see your coins.

@iFoggz
Copy link
Member

iFoggz commented May 22, 2017

yea i use coin control that how i devised up my coins between the grc addresses. I was doing some testing on how it would pick coins for staking and if u could stake more often. This has proven true it seems. I do plan to expand to all 10 staking address.

@tomasbrod
Copy link
Member Author

Fixed in #301. But more research is needed on why other Coins split the stake output to half.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants