Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor object retrieval from cache #48

Open
ahwagner opened this issue Sep 25, 2019 · 0 comments
Open

refactor object retrieval from cache #48

ahwagner opened this issue Sep 25, 2019 · 0 comments
Assignees
@ahwagner
Labels
bug Something isn't working
Milestone
v1.2

Comments

@ahwagner
Copy link
Member

Currently, _include_filter gets cached, and could mistakenly be retrieved from cache. Refactor calls to cache to always build new CivicRecord objects to prevent _include_filter (and other private variables) from propagating and potentially creating unintended behaviors.
@ahwagner ahwagner added the high priority This needs to be addressed ASAP label Sep 25, 2019
@ahwagner ahwagner added this to the v1.0 milestone Sep 25, 2019
@ahwagner ahwagner self-assigned this Sep 25, 2019
@ahwagner ahwagner added bug Something isn't working and removed high priority This needs to be addressed ASAP labels Sep 27, 2019
@ahwagner ahwagner modified the milestones: v1.0, v1.2 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahwagner ahwagner

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
1 participant
@ahwagner