Skip to content

Commit

Permalink
Fixes function searching and jumping (#389)
Browse files Browse the repository at this point in the history
- Reworks how function names are rendered on the functions page, meaning we don't need a hidden header element.
- Adds attr_list as an extension (I think it should always have been there?)
- Adds styling to make the (now visible) header elements match what was there before.
- Fixes sections not expanding when jumped to via permalink or searching
  • Loading branch information
Spoffy authored Aug 21, 2024
1 parent 6fb6e4d commit f58dbfa
Show file tree
Hide file tree
Showing 5 changed files with 509 additions and 977 deletions.
14 changes: 7 additions & 7 deletions help/en/docs/css/grist.css
Original file line number Diff line number Diff line change
Expand Up @@ -316,16 +316,16 @@ body {
}

/*
* We want headers for the sake of searching, but don't want to see the huge padding and
* surrounding empty paragraphs.
* Hide the empty paragraphs that are generated around headers in the expanding sections.
*/
.wm-page-content summary h4,
.wm-page-content summary p {
.wm-page-content summary p:empty {
display: none;
}
/* The <code> block that serves as a function header annoyingly gets auto-wrapped in a <p> */
.wm-page-content summary p:not(:first-child) {
display: inline-block;

/*
* Clean up any extra space used by paragraphs in the header.
*/
.wm-page-content summary p {
margin: 0;
}

Expand Down
Loading

0 comments on commit f58dbfa

Please sign in to comment.