Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to interceptors/logging/examples #567

Open
bwplotka opened this issue Apr 13, 2023 · 4 comments
Open

Add tests to interceptors/logging/examples #567

bwplotka opened this issue Apr 13, 2023 · 4 comments

Comments

@bwplotka
Copy link
Collaborator

We need unit tests for https://github.com/grpc-ecosystem/go-grpc-middleware/tree/main/interceptors/logging/examples, so we can avoid bugs like #559

@rohanraj7316
Copy link
Contributor

rohanraj7316 commented Apr 17, 2023

sorry, missed out here 565 is already in PR. do we need to replicate that here? or just to add test cases for all the example scenarios ?@bwplotka

@bwplotka
Copy link
Collaborator Author

I mean PR is not moving, so if you can actually fix it / add test that would be helpful. We need for all, but even one would be helpful 💪🏽

@rohanraj7316
Copy link
Contributor

just a bit of thought here. should I rename example_test.go to example.go and then add test case in example_test.go just a thought to improve naming convention or if you have anything better pls let me know @bwplotka

@bwplotka
Copy link
Collaborator Author

Sgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants