Fix build when using static Linux SDK #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
approved these changes
Mar 14, 2025
gjcairo
added
🔨 semver/patch
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Mar 19, 2025
…nsport` to `1.0.2` ### What changes were proposed in this pull request? This PR aims to upgrade - `gRPC Swift` to `2.1.2` - `gRPC Swift NIO Transport` to `1.0.2` ### Why are the changes needed? To bring the latest bug fixes. - https://github.com/grpc/grpc-swift/releases/tag/2.1.2 - https://github.com/grpc/grpc-swift/releases/tag/2.1.1 - grpc/grpc-swift#2206 - https://github.com/grpc/grpc-swift-nio-transport/releases/tag/1.0.2 - grpc/grpc-swift-nio-transport#80 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #23 from dongjoon-hyun/SPARK-51561. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a build issue when using the static Linux SDK. We were branching on
#if os(Linux)to decide whether a value we are using is an enum or a statically defined integer: Glibc declares it as an enum, whereas Darwin and Musl define it as an integer. We should make sure we are importing Glibc and not Musl when we consider it an enum, as otherwise the build will fail.