-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new option log #154
base: main
Are you sure you want to change the base?
Add new option log #154
Conversation
The default is set as true. This is so a user has a choice between verbose or just seeing that the file has been created and dosent't want to see all the information. Follows up https://github.com/gruntjs/grunt-contrib-concat/pull/145/files And fixes gruntjs#153
@shama or @vladikoff could you review and merge please. |
I don't think adding more options to plugins is a good way to solve this. We should think through and submit a rfc that gives end users more control over how grunt logs. |
Yes currently we carn't see what is created unless we add verbose which not only affects this but affects other scripts showing too much information that we doint want to see. |
Quoting @vladikoff's comment in #145:
This should be the right way to go, without adding any other option. |
I understand. The previous PR changing it to I recommend using a previous version of this plugin in the meantime. |
@shama could we revert that change then, and instead follow what you said and improve it in grunt instead please. |
Multiple other plugins switched to verbose only, users are concating over 100 files and logging everything by default is not a good solution. |
The default is set as true.
This is so a user has a choice between verbose or just seeing that the file has been created and dosent't want to see all the information.
Follows up #145
And fixes #153