You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems reasonable to allow users feed the chart with values for additional well-known labels like app.kubernetes.io/version
Describe alternatives you've considered
It is possible to inject the requested app.kubernetes.io/version label with additionalDeploymentLabels and additionalPodLabels, but allowing users to specify version as a dedicated Helm value seems reasonable in the spirit of all app.kubernetes.io labels or none.
Additional context
n/a
The text was updated successfully, but these errors were encountered:
Describe the solution you'd like
The chart already generates a bunch of well-known and recommended Kubernetes labels:
helm-kubernetes-services/charts/k8s-service/templates/_deployment_spec.tpl
Lines 88 to 90 in 8a50e60
It seems reasonable to allow users feed the chart with values for additional well-known labels like
app.kubernetes.io/version
Describe alternatives you've considered
It is possible to inject the requested
app.kubernetes.io/version
label withadditionalDeploymentLabels
andadditionalPodLabels
, but allowing users to specify version as a dedicated Helm value seems reasonable in the spirit of allapp.kubernetes.io
labels or none.Additional context
n/a
The text was updated successfully, but these errors were encountered: