From fb4b493406c3d78d99b4e26bce5f866fbed58813 Mon Sep 17 00:00:00 2001 From: Yousif Akbar <11247449+yhakbar@users.noreply.github.com> Date: Fri, 21 Feb 2025 11:40:02 -0500 Subject: [PATCH] fix: Adding explicit test for missing dependency (#3915) * fix: Adding explicit test for missing dependency * fix: Clarify what we're testing here --- test/fixtures/disabled/app/terragrunt.hcl | 17 +++++++++++------ .../disabled/{m1 => unit-disabled}/main.tf | 0 .../{m2 => unit-disabled}/terragrunt.hcl | 0 .../disabled/{m2 => unit-enabled}/main.tf | 0 .../{m1 => unit-enabled}/terragrunt.hcl | 0 .../{m3 => unit-without-enabled}/main.tf | 0 .../{m3 => unit-without-enabled}/terragrunt.hcl | 0 test/integration_test.go | 6 +++--- 8 files changed, 14 insertions(+), 9 deletions(-) rename test/fixtures/disabled/{m1 => unit-disabled}/main.tf (100%) rename test/fixtures/disabled/{m2 => unit-disabled}/terragrunt.hcl (100%) rename test/fixtures/disabled/{m2 => unit-enabled}/main.tf (100%) rename test/fixtures/disabled/{m1 => unit-enabled}/terragrunt.hcl (100%) rename test/fixtures/disabled/{m3 => unit-without-enabled}/main.tf (100%) rename test/fixtures/disabled/{m3 => unit-without-enabled}/terragrunt.hcl (100%) diff --git a/test/fixtures/disabled/app/terragrunt.hcl b/test/fixtures/disabled/app/terragrunt.hcl index 0baf76baa7..c084531be4 100644 --- a/test/fixtures/disabled/app/terragrunt.hcl +++ b/test/fixtures/disabled/app/terragrunt.hcl @@ -1,12 +1,12 @@ -dependency "m1" { - config_path = "../m1" +dependency "unit_without_enabled" { + config_path = "../unit-without-enabled" mock_outputs = { "output1" = "mocked_output1" } } -dependency "m2" { - config_path = "../m2" +dependency "unit_disabled" { + config_path = "../unit-disabled" enabled = false mock_outputs = { @@ -14,11 +14,16 @@ dependency "m2" { } } -dependency "m3" { - config_path = "../m3" +dependency "unit_enabled" { + config_path = "../unit-enabled" enabled = true mock_outputs = { "output3" = "mocked_output3" } } + +dependency "unit_missing" { + config_path = "../unit-missing" + enabled = false +} diff --git a/test/fixtures/disabled/m1/main.tf b/test/fixtures/disabled/unit-disabled/main.tf similarity index 100% rename from test/fixtures/disabled/m1/main.tf rename to test/fixtures/disabled/unit-disabled/main.tf diff --git a/test/fixtures/disabled/m2/terragrunt.hcl b/test/fixtures/disabled/unit-disabled/terragrunt.hcl similarity index 100% rename from test/fixtures/disabled/m2/terragrunt.hcl rename to test/fixtures/disabled/unit-disabled/terragrunt.hcl diff --git a/test/fixtures/disabled/m2/main.tf b/test/fixtures/disabled/unit-enabled/main.tf similarity index 100% rename from test/fixtures/disabled/m2/main.tf rename to test/fixtures/disabled/unit-enabled/main.tf diff --git a/test/fixtures/disabled/m1/terragrunt.hcl b/test/fixtures/disabled/unit-enabled/terragrunt.hcl similarity index 100% rename from test/fixtures/disabled/m1/terragrunt.hcl rename to test/fixtures/disabled/unit-enabled/terragrunt.hcl diff --git a/test/fixtures/disabled/m3/main.tf b/test/fixtures/disabled/unit-without-enabled/main.tf similarity index 100% rename from test/fixtures/disabled/m3/main.tf rename to test/fixtures/disabled/unit-without-enabled/main.tf diff --git a/test/fixtures/disabled/m3/terragrunt.hcl b/test/fixtures/disabled/unit-without-enabled/terragrunt.hcl similarity index 100% rename from test/fixtures/disabled/m3/terragrunt.hcl rename to test/fixtures/disabled/unit-without-enabled/terragrunt.hcl diff --git a/test/integration_test.go b/test/integration_test.go index aa53a1cd34..155798d637 100644 --- a/test/integration_test.go +++ b/test/integration_test.go @@ -3649,8 +3649,8 @@ func TestTerragruntDisabledDependency(t *testing.T) { for _, path := range []string{ util.JoinPath(tmpEnvPath, testFixtureDisabledModule, "app"), - util.JoinPath(tmpEnvPath, testFixtureDisabledModule, "m1"), - util.JoinPath(tmpEnvPath, testFixtureDisabledModule, "m3"), + util.JoinPath(tmpEnvPath, testFixtureDisabledModule, "unit-without-enabled"), + util.JoinPath(tmpEnvPath, testFixtureDisabledModule, "unit-enabled"), } { relPath, err := filepath.Rel(testPath, path) require.NoError(t, err) @@ -3658,7 +3658,7 @@ func TestTerragruntDisabledDependency(t *testing.T) { } for _, path := range []string{ - util.JoinPath(tmpEnvPath, testFixtureDisabledModule, "m2"), + util.JoinPath(tmpEnvPath, testFixtureDisabledModule, "unit-disabled"), } { relPath, err := filepath.Rel(testPath, path) require.NoError(t, err)