Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vdiffr for testing plots #191

Open
zkamvar opened this issue Jul 5, 2018 · 0 comments
Open

Use vdiffr for testing plots #191

zkamvar opened this issue Jul 5, 2018 · 0 comments

Comments

@zkamvar
Copy link
Member

zkamvar commented Jul 5, 2018

Travis came up with a bug from the new ggplot2 v3 (Tokyo Drift): https://travis-ci.org/grunwaldlab/poppr/jobs/400114394#L1575-L1577

  ── 1. Failure: mlg.table produces barplots (@test-plots.R#80)  ─────────────────
  pt$mapping$x not identical to ptb$mapping$x.
  Objects equal but not identical

This was caused by my attempt to test plots before vdiffr was a thing, but I think this may be the better way to go (and it may make things go faster in the long run).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant