Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inefficient implementation of boot.bruvo #226

Open
2 of 5 tasks
StaffanBetner opened this issue Aug 6, 2020 · 3 comments
Open
2 of 5 tasks

Fix inefficient implementation of boot.bruvo #226

StaffanBetner opened this issue Aug 6, 2020 · 3 comments

Comments

@StaffanBetner
Copy link

Please place an "x" in all the boxes that apply

  • I have the most recent version of poppr and R
  • I have found a bug
  • I want to request a new feature

I have found that boot.bruvo is very inefficiently implemented. It would be a better approach to store the distance matrices per locus, and sample them with replacement, and then calculate trees, instead of recalculating the distance matrices for every iteration.


@zkamvar
Copy link
Member

zkamvar commented Aug 7, 2020

Would you be willing to submit a PR for this?

@StaffanBetner
Copy link
Author

I only have some very ugly code that remedies this problem, but I will at least look into it. I suspect there are other speed improvments as well that can be done.

@zkamvar
Copy link
Member

zkamvar commented Aug 7, 2020

Thank you. For the record, with the advent of {styler}, ugly code is not much of a problem. For contributions, I require that they are formally tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants