visual: added design at client list page #17
+101
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying idp-fe-legacy with
|
| Latest commit: |
5a75748
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e562079d.idp-fe.pages.dev |
| Branch Preview URL: | https://16-visual-clients-list-page.idp-fe.pages.dev |
2paperstar
approved these changes
Aug 26, 2024
|
Title, Divider 등 일부 컴포넌트는 Profile 폴더에 있던 styled component를 복붙해 썼습니다! 그래서 코드중복이 발생했음을 알립니다. 그렇게 많은 양은 아니어서 복붙하여 사용했지만, 필요하다면 전역 컴포넌트로 만들어서 쓰면 될것같네요. |
아직 디자인이 확정되어서 어떻게 쓰일진 모르겠지만, 전역으로 만들어 쓰면 좋을 것 같아요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
after:
