Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include examples and/or link to knowyourmeme #92

Closed
justcomplaining opened this issue Mar 19, 2018 · 4 comments
Closed

Include examples and/or link to knowyourmeme #92

justcomplaining opened this issue Mar 19, 2018 · 4 comments

Comments

@justcomplaining
Copy link

It would be nice to quickly have access to an example of how the meme is usually used.

@gsantner
Copy link
Owner

gsantner commented Mar 19, 2018

With http://knowyourmeme.com/memes/hackerman's kym_id (know your meme ID) being hackerman, this could be added to metadata file.

If you do the required research and get all (avaiable) kym_ids for all memes in https://github.com/gsantner/memetastic-assets and send a PR to add that, than there could be a menuitem-option like Show meme info which displays the page then.

For this please modify https://github.com/gsantner/memetastic-assets/blob/master/%2B0A_memetastic.conf.json and add an kym_id to every (knowyourmeme available) image template:

{"title":"10 Advice Mallard","filename":"10_Advice_Mallard.jpg","tags":["animals"]},
{"title":"10 Doge","filename":"10_Doge.jpg","tags":["animals"]}

-->

{"title":"10 Advice Mallard","filename":"10_Advice_Mallard.jpg","tags":["animals"],"kym_id":"ADVICE MALLARD"},
{"title":"10 Doge","filename":"10_Doge.jpg","tags":["animals"],"kym_id":"DOGE"}

Waiting for a PR.

@justcomplaining
Copy link
Author

Thank you very much for the quick reply! Maybe I'll do that sometime, seems simple enough. Not enough time atm but I'll keep it in mind!

@gsantner
Copy link
Owner

https://media.giphy.com/media/3o85xtLX7zCyeeWGLC/giphy.gif

@gsantner
Copy link
Owner

#126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants