Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm run build-backend #35

Closed
endorpersand opened this issue Oct 17, 2024 · 0 comments · Fixed by #37
Closed

Fix npm run build-backend #35

endorpersand opened this issue Oct 17, 2024 · 0 comments · Fixed by #37

Comments

@endorpersand
Copy link
Collaborator

This script rebuilds the backend, but inconsistently saves it into node_modules if it already exists. You can tell because running npm run build-backend will result in a message along the lines of:

  • up to date, audited 782 packages in 899ms (if lc3-backend is not resaved)
  • changed 1 package, and audited 782 packages in 2s (if lc3-backend is resaved)

This is annoying for development, but doesn't affect the build process, because the GitHub Actions starts off with a fresh node_modules.


Some solutions can be done to patch this for development:

  1. Not using --install-links in the build script
  2. Instead using pnpm i lc3-backend@../backend
  3. Manually removing the package from node_modules before dev

(1) breaks builds because it symlinks lc3-backend into node_modules (which causes Electron Forge + Vite to freak)
(2) requires pnpm (and may also break builds(?))
(3) is annoying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant