Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve GT-Scheduler .ics export puts all classes 1 hour early #336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Resolve GT-Scheduler .ics export puts all classes 1 hour early #336

wants to merge 1 commit into from

Conversation

cgensheimer
Copy link

@cgensheimer cgensheimer commented Jan 10, 2025 •
edited
Loading

…e0161cbf1cd

Summary

Resolves #334 and mentioned in #265

  • Removed the static EST offset (bug exposed by Daylight Savings Time)
  • Date objects should already be local timezone aware for calendar exports
  • The vendor file for ICS does have a TODO for more explicit timezone handling.

How to Test

Manual tests can be done by adjusting your machine local time and observing ICS file contents for DTSTART and DTEND.

Expected behavior
The correct date and times for each class are uploaded as events to your Google Calendar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GT-Scheduler .ics export puts all classes 1 hour early
1 participant
@cgensheimer