close #39 #40
Open
close #39 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todd-a-jacobs
commented
Jun 8, 2020
todd-a-jacobs
commented
- d88026e unconstrain guard-bundler version
- acba86f move guard-compat to runtime dependency
- 8ea72b1 constrain cucumber (> 3.1, < 4.0)
- 9993179 feed rubocop
- bd8e5d9 bump guard-cucumber to 3.0.1
bundler (>= 1.6) conflicts with guard-bundler 2.0.0, which wants bundler (~> 1.0).
Guard::Cucumber::NotificationFormatter breaks on Cucumber 4.0.0, and possibly others in the 4.x series.
- Rubocop objects to the use of single-quotes strings. - Allow `bundle exec rubocop -a` to resolve the problem.
- increment patch version - fixes guard#39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.