Fix maven release workflow #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adamnfish
force-pushed
the
fix-maven-release-workflow
branch
2 times, most recently
from
a488094 to
e060780
Compare
rtyley
reviewed
Jul 26, 2024
This replaces the old sonatype password secret. We also rename the file to make it consistent with other release workflows in the organisation.
adamnfish
force-pushed
the
fix-maven-release-workflow
branch
from
e060780 to
9f1669a
Compare
rtyley
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Sorry I missed this with the bulk update script for guardian/gha-scala-library-release-workflow#23 - the problem was the script is hard-coded to look at .github/workflows/release.yml - and this repo used release.yaml (yaml with an 'a') - thanks for renaming to make it consistent!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This replaces the old sonatype password secret.
We also rename the file to make it consistent with other release workflows in the organisation.
How to test
We'll run the release workflow straight after merging this PR, it should fix the error seen in the previous invocation:
https://github.com/guardian/anghammarad/actions/runs/10109326671