Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudquery): Collect NS1 data #337

Closed
wants to merge 1 commit into from
Closed

feat(cloudquery): Collect NS1 data #337

wants to merge 1 commit into from

Conversation

akash1810
Copy link
Member

What does this change?

Adds the (WIP) NS1 source plugin from https://github.com/guardian/cq-source-ns1 to collect NS1 data.

Currently, only zone information is returned, see guardian/cq-source-ns1#8.

How has it been verified?

TBD.

Adds the (WIP) NS1 source plugin from https://github.com/guardian/cq-source-ns1 to collect NS1 data.

Currently, only zone information is returned, see guardian/cq-source-ns1#8.
name: 'guardian-ns1',
path: 'ghcr.io/guardian/cq-source-ns1',
version: `v${Versions.CloudqueryNS1}`,
registry: 'docker',
Copy link
Member Author

@akash1810 akash1810 Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaScript based plugins need to be distributed as Docker containers.

Sadly this is not compatible with our infra, which uses ECS, as when running the task with ECS the following error is logged:

failed to list Docker images: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

This will be because ECS tasks do not have access the the Docker daemon running on the host.

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days

@github-actions github-actions bot added the Stale label Oct 30, 2023
@akash1810
Copy link
Member Author

aws/containers-roadmap#1356 should help here.

@github-actions github-actions bot removed the Stale label Nov 1, 2023
Copy link

github-actions bot commented Dec 4, 2023

This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days

@github-actions github-actions bot added the Stale label Dec 4, 2023
Copy link

github-actions bot commented Dec 7, 2023

This PR was closed because it has been stalled for 3 days with no activity.

@github-actions github-actions bot closed this Dec 7, 2023
@akash1810 akash1810 deleted the aa/ns1 branch March 19, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant