Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit rule button breaks after selecting a rule #422

Open
simonbyford opened this issue Sep 1, 2023 · 1 comment
Open

Edit rule button breaks after selecting a rule #422

simonbyford opened this issue Sep 1, 2023 · 1 comment

Comments

@simonbyford
Copy link
Contributor

To reproduce:

  1. Make sure you have the right permissions to edit rules
  2. Select any rule using the checkbox on the left
  3. Click any edit button on the right. They don't work as expected and show an incorrect tooltip about permissions

Not sure what the expected behaviour should be here. Having both checkboxes and edit buttons is a little confusing?

select-bug

@samanthagottlieb
Copy link
Contributor

We chatted about check boxes vs edit pencils a few weeks ago actually. I believe check boxes were added to enable batch editing, but we did discuss how the presence of both could be confusing. That tooltip about permissions should definitely not appear though, well spotted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants