-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pressing Alt+any key closes app when using NetDriver #3916
Comments
Looks like terminal sends Esc,F:
Should be pretty easy fix in #3837 , more complicated in NetDriver/NetEvents (which v2 should replace at some point). |
Ok its actually slightly more complex because we have to distinguish between SS3 patterns and Alt patterns. For example.
But AnsiParser is currently set up to assume input stream is deterministic - i.e. it has minimal timing awareness. So if we see EscO we cannot just release it as Alt - we need to wait and see if P follows in which case its F1. There is some timing already built in with private IEnumerable<T> ReleaseParserHeldKeysIfStale ()
{
if (Parser.State == AnsiResponseParserState.ExpectingEscapeSequence && DateTime.Now - Parser.StateChangedAt > _escTimeout)
{
return Parser.Release ().Select (o => o.Item2);
}
return [];
} I think it should be possible to tap in at the release stage and do the Alt processing here. |
I have fixed in #3837 for the v2 driver, please try running v2net driver on that branch. works for single keypress and held down |
Describe the bug
Pressing Alt+any key closes app when using NetDriver in v2_release
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The 'File' menu should open
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: