Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor controller code #41

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Refactor controller code #41

wants to merge 36 commits into from

Commits on Oct 5, 2024

  1. added initial implementation to resolve the bug

    @amirbavand
    amirbavand committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    0228de6 View commit details
    Browse the repository at this point in the history

  2. fixed some bugs

    @amirbavand
    amirbavand committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    28dcabc View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. addd required files to implement integration test for deletion scenario

    @amirbavand
    amirbavand committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    412936a View commit details
    Browse the repository at this point in the history

  2. addd required files to implement integration test for deletion scenario

    @amirbavand
    amirbavand committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    5c1a286 View commit details
    Browse the repository at this point in the history

  3. added required integration test

    @amirbavand
    amirbavand committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    5028c0b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix-bug-deletion

    @amirbavand
    amirbavand committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    f16a8ae View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. added new line to file

    @amirbavand
    amirbavand committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2cea244 View commit details
    Browse the repository at this point in the history

  2. reset the file

    @amirbavand
    amirbavand committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    13875bc View commit details
    Browse the repository at this point in the history

  3. delete some of log statements

    @amirbavand
    amirbavand committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b8e52a1 View commit details
    Browse the repository at this point in the history

  4. fixed some lint issues

    @amirbavand
    amirbavand committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    fd8b799 View commit details
    Browse the repository at this point in the history

  5. fixed some more lint issues

    @amirbavand
    amirbavand committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6e1dbf7 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. addressed review comments

    @amirbavand
    amirbavand committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    5996c64 View commit details
    Browse the repository at this point in the history

  2. used map instead of list to delete the resources

    @amirbavand
    amirbavand committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    38ff5be View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. refactord code for dynamicreconciler

    @amirbavand
    amirbavand committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    9f83ada View commit details
    Browse the repository at this point in the history

  2. refactored code for dynamicreconciler and removed unnecessary codes

    @amirbavand
    amirbavand committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    57adccc View commit details
    Browse the repository at this point in the history

  3. more refactoring

    @amirbavand
    amirbavand committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    cdfec43 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Merge branch 'main' into refactor-controller-code

    @amirbavand
    amirbavand committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    cb3d04a View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. fixed a but in dynamicreconciler

    @amirbavand
    amirbavand committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    b772291 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor-controller-code

    @amirbavand
    amirbavand committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    daf91d5 View commit details
    Browse the repository at this point in the history

  3. fixed a runtime error

    @amirbavand
    amirbavand committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    24e8500 View commit details
    Browse the repository at this point in the history

  4. remove unused function CheckIfResourceExists

    @amirbavand
    amirbavand committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    135cea3 View commit details
    Browse the repository at this point in the history

  5. refactored code for testing

    @amirbavand
    amirbavand committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c326f0d View commit details
    Browse the repository at this point in the history

  6. added unit tests for util functions

    @amirbavand
    amirbavand committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    cdea02f View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. added some new changes for make code testable

    @amirbavand
    amirbavand committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    4113333 View commit details
    Browse the repository at this point in the history

  2. removed singleton object for sqliterepository and pass inject it as d… 

    …ependency
    @amirbavand
    amirbavand committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    335094a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor-controller-code

    @amirbavand
    amirbavand committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    7d7a1a7 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. pass watchmanager interface instead of watchmanager

    @amirbavand
    amirbavand committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    99ce2cf View commit details
    Browse the repository at this point in the history

  2. added unit tests for dynamic_reconciler

    @amirbavand
    amirbavand committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    502768a View commit details
    Browse the repository at this point in the history

  3. fix lint issues

    @amirbavand
    amirbavand committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    e2fdf40 View commit details
    Browse the repository at this point in the history

  4. changed package names for test files

    @amirbavand
    amirbavand committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    06b4593 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. applied some of the review comments

    @amirbavand
    amirbavand committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    cd3ac7e View commit details
    Browse the repository at this point in the history

  2. fix issue with unit test

    @amirbavand
    amirbavand committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6c74a8b View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. remove some not needed lint errors

    @amirbavand
    amirbavand committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    60df66a View commit details
    Browse the repository at this point in the history

  2. changed watchmanagerinterface to watchmanager

    @amirbavand
    amirbavand committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    40e2efe View commit details
    Browse the repository at this point in the history

  3. Update watchmanager.go 

    remove tostring from resourceidentifire
    @amirbavand
    amirbavand committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    182fc3f View commit details
    Browse the repository at this point in the history

  4. remove duplicated method

    @amirbavand
    amirbavand committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    b31ed27 View commit details
    Browse the repository at this point in the history