wip,test: add rounding test case #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two test cases from the discussion gunnarmorling#5 (comment) Neither all implementations match baseline nor they match precise value of `33.6+31.7+21.9+14.6=25.5`: ``` $ ./test_all.sh src/test/resources/samples/measurements-rounding-baseline.txt 2>/dev/null | tee /tmp/rounding-baseline.log FAIL armandino FAIL artsiomkorzun PASS baseline PASS bjhara PASS criccomini FAIL ddimtirov FAIL ebarlas FAIL filiphr FAIL itaske PASS jgrateron FAIL khmarbaise FAIL kuduwa-keshavram PASS lawrey PASS moysesb FAIL nstng PASS padreati FAIL palmr PASS richardstartin FAIL royvanrijn PASS seijikun PASS spullara PASS truelive $ ./test_all.sh src/test/resources/samples/measurements-rounding-precise.txt 2>/dev/null | tee /tm p/rounding-precise.log PASS armandino PASS artsiomkorzun FAIL baseline FAIL bjhara FAIL criccomini FAIL ddimtirov PASS ebarlas PASS filiphr FAIL itaske FAIL jgrateron PASS khmarbaise FAIL kuduwa-keshavram FAIL lawrey FAIL moysesb PASS nstng FAIL padreati PASS palmr FAIL richardstartin PASS royvanrijn FAIL seijikun FAIL spullara FAIL truelive $ diff -y /tmp/rounding-baseline.log /tmp/rounding-precise.log FAIL armandino | PASS armandino FAIL artsiomkorzun | PASS artsiomkorzun PASS baseline | FAIL baseline PASS bjhara | FAIL bjhara PASS criccomini | FAIL criccomini FAIL ddimtirov FAIL ddimtirov FAIL ebarlas | PASS ebarlas FAIL filiphr | PASS filiphr FAIL itaske FAIL itaske PASS jgrateron | FAIL jgrateron FAIL khmarbaise | PASS khmarbaise FAIL kuduwa-keshavram FAIL kuduwa-keshavram PASS lawrey | FAIL lawrey PASS moysesb | FAIL moysesb FAIL nstng | PASS nstng PASS padreati | FAIL padreati FAIL palmr | PASS palmr PASS richardstartin | FAIL richardstartin FAIL royvanrijn | PASS royvanrijn PASS seijikun | FAIL seijikun PASS spullara | FAIL spullara PASS truelive | FAIL truelive ``` Its also interesting that e.g. `itaske` produces different results between runs and thus may pass or fail sporadically. For gunnarmorling#49
|
Hey @AlexanderYastrebov, thanks for creating this. I'm gonna close it in favour of #375 where we have another test which gets at that rounding issue. See the discussion over there for more details, the general idea is to fix the baseline, keep existing entries as-is, but require to conform to the correct behavior for new/updated entries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two test cases from the discussion #5 (comment)
Neither all implementations match baseline nor they match precise value of
33.6+31.7+21.9+14.6=25.5:Its also interesting that e.g.
itaskeproduces different results between runs and thus may pass or fail sporadically.For #49