Manager: Add legendary challenge mode

Author: Sejsel

ArcdpsLogManager/ArcdpsLogManager.csproj

@@ -17,7 +17,7 @@
         Each new log data update causes a revision increase.
         See LogDataUpdater for the updates.
         -->
-        <Version>1.11.0.1</Version>
+        <Version>1.11.0.2</Version>
     </PropertyGroup>
     <ItemGroup>
         <PackageReference Include="DebounceThrottle" Version="2.0.0" />

ArcdpsLogManager/CHANGELOG.md

@@ -13,7 +13,8 @@ This is the full changelog of the arcdps Log Manager.
   - oh, and it has a detailed history
   - relies on your logs, does not use the API
 - Added Cosmic Observatory CM detection
-- Added Temple of Febe CM detection
+- Added Temple of Febe CM/LM detection
+- Added filtering for Legendary Challenge Mode encounters (Temple of Febe)
 
 #### Fixes
 - Fixed dps.report uploads failing when hitting the rate limit

ArcdpsLogManager/Controls/Filters/LogFilterPanel.cs

@@ -64,12 +64,15 @@ public LogFilterPanel(LogCache logCache, ApiData apiData, LogDataProcessor logPr
 			var normalModeCheckBox = new CheckBox {Text = "Normal"};
 			normalModeCheckBox.CheckedBinding.Bind(this, x => x.Filters.ShowNormalModeLogs);
 			BindEnabled(normalModeCheckBox);
-			var challengeModeCheckBox = new CheckBox {Text = "Challenge"};
-			challengeModeCheckBox.CheckedBinding.Bind(this, x => x.Filters.ShowChallengeModeLogs);
-			BindEnabled(challengeModeCheckBox);
 			var emboldenedCheckBox = new CheckBox {Text = "Emboldened"};
 			emboldenedCheckBox.CheckedBinding.Bind(this, x => x.Filters.ShowEmboldenedModeLogs);
 			BindEnabled(emboldenedCheckBox);
+			var challengeModeCheckBox = new CheckBox {Text = "Challenge"};
+			challengeModeCheckBox.CheckedBinding.Bind(this, x => x.Filters.ShowChallengeModeLogs);
+			BindEnabled(challengeModeCheckBox);
+			var legendaryModeCheckBox = new CheckBox {Text = "Legendary"};
+			legendaryModeCheckBox.CheckedBinding.Bind(this, x => x.Filters.ShowLegendaryChallengeModeLogs);
+			BindEnabled(legendaryModeCheckBox);
 
 			var nonFavoritesCheckBox = new CheckBox {Text = "☆ Non-favorites"};
 			nonFavoritesCheckBox.CheckedBinding.Bind(this, x => x.Filters.ShowNonFavoriteLogs);
@@ -177,10 +180,15 @@ public LogFilterPanel(LogCache logCache, ApiData apiData, LogDataProcessor logPr
 					BeginHorizontal();
 					{
 						Add(normalModeCheckBox);
-						Add(challengeModeCheckBox);
 						Add(emboldenedCheckBox);
 					}
 					EndHorizontal();
+					BeginHorizontal();
+					{
+						Add(challengeModeCheckBox);
+						Add(legendaryModeCheckBox);
+					}
+					EndHorizontal();
 				}
 				EndGroup();
 				BeginGroup("Date", new Padding(4, 0, 4, 2), spacing: new Size(4, 4));

ArcdpsLogManager/Controls/LogDetailPanel.cs

@@ -63,6 +63,7 @@ public LogData LogData
 					EncounterMode.Unknown => "",
 					EncounterMode.Normal => "",
 					EncounterMode.Challenge => "Challenge Mode",
+					EncounterMode.LegendaryChallenge => "Legendary Challenge Mode",
 					EncounterMode.Emboldened1 => "Emboldened 1",
 					EncounterMode.Emboldened2 => "Emboldened 2",
 					EncounterMode.Emboldened3 => "Emboldened 3",

ArcdpsLogManager/Logs/Filters/LogFilters.cs

@@ -25,6 +25,7 @@ public sealed class LogFilters : ILogFilter, INotifyPropertyChanged
 		private bool showEmboldenedLogs = true;
 		private bool showNormalModeLogs = true;
 		private bool showChallengeModeLogs = true;
+		private bool showLegendaryChallengeModeLogs = true;
 		private bool showNonFavoriteLogs = true;
 		private bool showFavoriteLogs = true;
 		private DateTime? minDateTime = null;
@@ -164,6 +165,17 @@ public bool ShowChallengeModeLogs
 				OnPropertyChanged();
 			}
 		}
+		
+		public bool ShowLegendaryChallengeModeLogs
+		{
+			get => showLegendaryChallengeModeLogs;
+			set
+			{
+				if (value == showLegendaryChallengeModeLogs) return;
+				showLegendaryChallengeModeLogs = value;
+				OnPropertyChanged();
+			}
+		}
 
 		public bool ShowNonFavoriteLogs
 		{
@@ -322,6 +334,7 @@ private bool FilterByEncounterMode(LogData log)
 			return (log.EncounterMode == EncounterMode.Normal && ShowNormalModeLogs) ||
 			       (log.EncounterMode == EncounterMode.Unknown && ShowNormalModeLogs) ||
 			       (log.EncounterMode == EncounterMode.Challenge && ShowChallengeModeLogs) ||
+			       (log.EncounterMode == EncounterMode.LegendaryChallenge && ShowLegendaryChallengeModeLogs) ||
 			       (log.EncounterMode.IsEmboldened() && ShowEmboldenedModeLogs);
 		}
 

ArcdpsLogManager/Logs/Updates/LogDataUpdater.cs

@@ -190,6 +190,9 @@ x.Profession is Profession.Thief or Profession.Engineer or Profession.Ranger
 				"Fix success detection for Cosmic Observatory"),
 			// When adding a new update, you need to increase the revision (last value) of the version in the .csproj file
 			// unless the version changes more significantly, in that case it can be reset to 0.
+			new LogUpdate(log => log.ParsingVersion < new Version(1, 11, 0, 2)
+			                     && log.Encounter == Encounter.TempleOfFebe,
+				"Add support for Temple of Febe Legendary CM"),
 		};
 
 		public IEnumerable<LogUpdateList> GetUpdates(IEnumerable<LogData> logs)

ArcdpsLogManager/Sections/Clears/MultipartEncounter.cs

@@ -56,6 +56,6 @@ public bool IsChallengeModeSatisfiedBy(IEnumerable<LogData> logs)
 	{
 		return Encounters.All(encounter => logs.Any(log =>
 			log.ParsingStatus == ParsingStatus.Parsed && log.EncounterResult == EncounterResult.Success && log.Encounter == encounter &&
-			log.EncounterMode == EncounterMode.Challenge));
+			log.EncounterMode is EncounterMode.Challenge or EncounterMode.LegendaryChallenge));
 	}
 }

ArcdpsLogManager/Sections/Clears/NormalEncounter.cs

@@ -68,6 +68,6 @@ public bool IsSatisfiedBy(IEnumerable<LogData> logs)
 	public bool IsChallengeModeSatisfiedBy(IEnumerable<LogData> logs)
 	{
 		return logs.Any(log => log.ParsingStatus == ParsingStatus.Parsed && log.EncounterResult == EncounterResult.Success && log.Encounter == Encounter &&
-		                       log.EncounterMode == EncounterMode.Challenge);
+		                       log.EncounterMode is EncounterMode.Challenge or EncounterMode.LegendaryChallenge);
 	}
 }

ArcdpsLogManager/Sections/LogList.cs

@@ -165,6 +165,8 @@ private GridView<LogData> ConstructLogGridView(LogDetailPanel detailPanel, Multi
 					{
 						switch (x.EncounterMode)
 						{
+							case EncounterMode.LegendaryChallenge:
+								return "LM";
 							case EncounterMode.Challenge:
 								return "CM";
 							case EncounterMode.Normal:

EVTCAnalytics/GameData/GameBuilds.cs

@@ -14,5 +14,13 @@ public static class GameBuilds
 		/// The release of Cosmic Observatory Challenge Mode, which revamped the health of the normal mode as well.
 		/// </summary>
 		public static int CosmicObservatoryCMRelease = 153978;
+		
+		/// <summary>
+		/// The Temple of Febe Challenge Mode health fix unifying the health in first phase and in later phases.
+		/// </summary>
+		/// <remarks>
+		/// Note that there were more health changes to this encounter, make sure this is what you mean.
+		/// </remarks>
+		public static int TempleOfFebeHealthFix = 158968;
 	}
 }

EVTCAnalytics/Processing/EncounterDataProvider.cs

@@ -634,8 +634,24 @@ private IEncounterData GetPvEEncounterData(Encounter encounter, Agent mainTarget
 				}
 				case Encounter.TempleOfFebe:
 				{
+					// NM: before CM release 47,188,800, after CM release: 53,087,400
+					// CM: on release 106,174,800 first phase, second phase 159M
+					// CM: after first fix 130,064,136 in all phases
+					// CM: made easier at 106,174,800 health (2024-03-19)
+					// Legendary Challenge: keeps 130,064,136 (introduced in 2024-03-19)
+					
+					// Achievements were given retroactively, so we count everything above 106,174,800
+					// as legendary challenge even before its introduction
 					return GetDefaultBuilder(encounter, mainTarget)
-						.WithModes(new AgentHealthModeDeterminer(mainTarget, 60_000_000))
+						.WithModes(new ConditionalModeDeterminer(
+							// The first version of CM with varying health is also recognized as legendary challenge.
+							// There were no publicly known kills of this fight, but it makes sense to recognize
+							// the attempts as the legendary version.
+							(gameBuild != null && gameBuild < GameBuilds.TempleOfFebeHealthFix,
+								new AgentHealthModeDeterminer(mainTarget, 60_000_000, EncounterMode.LegendaryChallenge)),
+							(true, new FallbackModeDeterminer(
+								new AgentHealthModeDeterminer(mainTarget, 107_000_000, EncounterMode.LegendaryChallenge),
+								new AgentHealthModeDeterminer(mainTarget, 60_000_000, EncounterMode.Challenge)))))
 						.Build();
 				}
 				default:

EVTCAnalytics/Processing/Encounters/Modes/EncounterMode.cs

@@ -38,6 +38,10 @@ public enum EncounterMode
 		/// 5 stacks of Emboldened (easy mode; extra stats).
 		/// </summary>
 		Emboldened5,
+		/// <summary>
+		/// A harder version of a challenge mode.
+		/// </summary>
+		LegendaryChallenge,
 	}
 
 	public static class EncounterModeExtensions