Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several question about the paper #16

Open
Josh00-Lu opened this issue Aug 11, 2022 · 3 comments
Open

Several question about the paper #16

Josh00-Lu opened this issue Aug 11, 2022 · 3 comments

Comments

@Josh00-Lu
Copy link

Josh00-Lu commented Aug 11, 2022

  1. Main Paper:equation(1),it should be $\sqrt{1-\alpha _ t }w $
  2. Supplement Paper : Algorithm 4, line 5, the same problem with 1)
  3. Supplement Paper : Algorithm 1, line 13,14 & Algorithm 2, line 7,8. Shouldn't these $x_{ \tau _s }^{(i)}$ be with hat ?
@gwang-kim
Copy link
Owner

As I told you by e-mail, I appreciate your findings!
I'll fix them and update the arxiv submission and I will ask the chair of CVPR 2022 whether I can fix the typo.

@Josh00-Lu
Copy link
Author

As I told you by e-mail, I appreciate your findings! I'll fix them and update the arxiv submission and I will ask the chair of CVPR 2022 whether I can fix the typo.

Yes... Actually, this issue was opened before I mailed. Haha... Anyway, this issue can still let others know there's some mistypings in paper when reading your codes. That may reduce a lot of avoidable confusions.

@gwang-kim
Copy link
Owner

Good idea!
I reopened the issue to let other people know the erratra in our paper.
I also update the arXiv paper with the correction and request the chairs of CVPR 2022 to indicate changes.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants