Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set java 11 as minimum for sample apps templates #10019

Merged
merged 4 commits into from
Oct 31, 2024
Merged

set java 11 as minimum for sample apps templates #10019

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c78d0f3
set java 11 as minimum for sample apps templates
vegegoku Oct 27, 2024
e4060d1
use release tag instead and update comments
vegegoku Oct 27, 2024
dfa9042
revert release tag in gwt plugin
vegegoku Oct 30, 2024
0866c88
replace the source and target properties with release property
vegegoku Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions user/src/com/google/gwt/user/tools/templates/ant/build.xmlsrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<mkdir dir="@warFolder/WEB-INF/classes"/>
<javac srcdir="@srcFolder" includes="**" encoding="utf-8"
destdir="@warFolder/WEB-INF/classes"
source="1.7" target="1.7" nowarn="true"
source="11" target="11" nowarn="true"
debug="true" debuglevel="lines,vars,source">
<classpath refid="project.class.path"/>
</javac>
Expand Down Expand Up @@ -70,7 +70,7 @@
@testTargetsBegin
<target name="javac.tests" depends="javac" description="Compiles test code">
<javac srcdir="@testFolder" includes="**" encoding="utf-8"
source="1.7" target="1.7" nowarn="true"
source="11" target="11" nowarn="true"
destdir="@warFolder/WEB-INF/classes"
debug="true" debuglevel="lines,vars,source">
<classpath location="@junitJar"/>
Expand Down
12 changes: 6 additions & 6 deletions user/src/com/google/gwt/user/tools/templates/maven/pom.xmlsrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@

<properties>

<!-- Setting maven.compiler.source to something different to 1.8
<!-- Setting maven.compiler.source to something different to 11
needs that you configure the sourceLevel in gwt-maven-plugin since
GWT compiler 2.8 and above requires 1.8 (see gwt-maven-plugin block below) -->
<maven.compiler.source>1.8</maven.compiler.source>
vegegoku marked this conversation as resolved.
Show resolved Hide resolved
<maven.compiler.target>1.8</maven.compiler.target>
GWT compiler 2.12.0 and above requires 11 (see gwt-maven-plugin block below) -->
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>

<!-- Don't let your Mac use a crazy non-standard encoding -->
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Expand Down Expand Up @@ -83,9 +83,9 @@
<moduleName>@moduleName</moduleName>
<moduleShortName>@moduleShortName</moduleShortName>
<failOnError>true</failOnError>
<!-- GWT compiler 2.8 and above requires 1.8, hence define sourceLevel here if you use
<!-- GWT compiler 2.12.0 and above requires 11, hence define sourceLevel here if you use
a different source language for java compilation -->
<sourceLevel>1.8</sourceLevel>
<release>11</release>
vegegoku marked this conversation as resolved.
Show resolved Hide resolved
<!-- Compiler configuration -->
<compilerArgs>
<!-- Ask GWT to create the Story of Your Compile (SOYC) (gwt:compile) -->
Expand Down