Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. edits ahead of may release #552

Merged
merged 7 commits into from
May 1, 2024
Merged

Misc. edits ahead of may release #552

merged 7 commits into from
May 1, 2024

Conversation

maxturer
Copy link
Contributor

This fixes issue #545 as well as several unticketed issues.
Includes:

  • fix for issue where when logged in, search bar displays "all" even when other options are selected
  • fix for issue where when other options in search bar are selected, search bar resizes itself
  • HTML titles given to advanced search, search results, and a few static pages
  • login page redesigned and reordered
  • red "x" removed from start over button on dashboard
  • content edits to "share your work" page based on ScholComm feedback
  • fix for issue where default "collection" icon not displayed in certain situations (see Files without thumbnails result in broken links #533)

If I missed anything minor that we want before the release (or if I should change titles on dashboard pages that don't have them, either), let me know, because this is a good branch to add those to.

Copy link
Contributor

@dolsysmith dolsysmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the new login page! And everything else works as expected, with the caveat that I can't replicate the issue with collection-level thumbnails on my dev server...

@maxturer
Copy link
Contributor Author

maxturer commented May 1, 2024

Great! I'll go ahead and merge.
Also, it's definitely not clear what triggers the no-thumbnail bug, but I've sometimes been able to trigger it by filling a new collection with works that have no associated files (sometimes, frustratingly, but not every time).

@maxturer maxturer merged commit 95551aa into master May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants