Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build argument to Dockerfiles for release version #1132

Open
dolsysmith opened this issue Dec 2, 2022 · 2 comments
Open

Add build argument to Dockerfiles for release version #1132

dolsysmith opened this issue Dec 2, 2022 · 2 comments
Assignees

Comments

@dolsysmith
Copy link
Contributor

Modify the Dockerfiles to use an optional build argument, which can be passed in via docker-compose. The build argument would have a default value of release, but it could be set to master in cases where we want the images to be the latest in the repository (and not those from the latest release).

@dolsysmith
Copy link
Contributor Author

Assuming the goal is for someone to be able to run the latest version on master without building the images from the various repos, the solution is to pass the arguments to the builds in Dockerhub. This can be done, apparently, with a build hook script, which would pass the correct build argument based on the Docker tag (i.e., master for the latest code in master, and the appropriate release tag otherwise).

@dolsysmith dolsysmith self-assigned this Dec 5, 2022
@dolsysmith
Copy link
Contributor Author

This is working in sfm-twitter-harvester. Before implementing the hook in the other repos (including sfm-ui), need to confirm that the updated version of pytz in sfm-utils is working with the code in those repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant