-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] cursive exits immediately when asked to display a string with a null byte #780
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
...before sending the &str to ncurses backend, this is done for cursive's print_at() and print_at_rep() only! otherwise, nothing would get printed, silently. Why delete \0 instead of replace with eg. space? this explains it best: gyscos#778 (comment) This also fixes warnings about unused Result. Closes: gyscos#780
...before sending the &str to ncurses backend, this is done for cursive's print_at() and print_at_rep() only! otherwise, nothing would get printed, silently. Why delete \0 instead of replace with eg. space? this explains it best: gyscos#778 (comment) This also fixes warnings about unused Result. Closes: gyscos#780
...before sending the &str to ncurses backend, this is done for cursive's print_at() and print_at_rep() only! otherwise, nothing would get printed, silently. Why delete \0 instead of replace with eg. space? this explains it best: gyscos#778 (comment) This also fixes warnings about unused Result. Closes: gyscos#780
...before sending the &str to ncurses backend, this is done for cursive's print_at() and print_at_rep() only! otherwise, nothing would get printed, silently. Why delete \0 instead of replace with eg. space? this explains it best: gyscos#778 (comment) This also fixes warnings about unused Result. Closes: gyscos#780
...before sending the &str to ncurses backend, this is done for cursive's print_at() and print_at_rep() only! otherwise, nothing would get printed, silently. Why delete \0 instead of replace with eg. space? this explains it best: gyscos#778 (comment) This also fixes warnings about unused Result. Closes: gyscos#780
...before sending the &str to ncurses backend, this is done for cursive's print_at() and print_at_rep() only! otherwise, nothing would get printed, silently. Why delete \0 instead of replace with eg. space? this explains it best: gyscos#778 (comment) This also fixes warnings about unused Result. Closes: gyscos#780
...before sending the &str to ncurses backend, this is done for cursive's print_at() and print_at_rep() only! otherwise, nothing would get printed, silently. Why delete \0 instead of replace with eg. space? this explains it best: gyscos#778 (comment) This also fixes warnings about unused Result. Closes: gyscos#780
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
The crash should now be fixed with the latest commit, which ignores Note that on my terminal, the handling of The same happens on gnone-terminal. Might depend on the font used. This happens both with |
Fix has now be released. I'll close this, but feel free to re-open if you think you're still having this issue. |
Describe the bug
cursive programs exit immediately when asked to display a string with a null byte. No error message is shown, and there doesn't seem to be a
panic
To Reproduce
MWE:
This program should display a
TextView
, but instead it exists without any complaint.Expected behavior
This program should display a
TextView
, or at least panic with an error message, so that users ofcursive
know that null bytes are not allowedScreenshots
no screenshot available
Environment
Additional context
I found this while fixing janstarke/regview#8
The text was updated successfully, but these errors were encountered: