the following are fixed: warning: redundant pattern matching, consider using `is_some()` --> /home/user/1tmp/ncurses_things/cursive/cursive-macros/src/builder/recipe.rs:354:16 | 354 | if let Some(_) = is_option_type(&field.ty) { | -------^^^^^^^---------------------------- help: try: `if is_option_type(&field.ty).is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default warning: unneeded `return` statement --> /home/user/1tmp/ncurses_things/cursive/cursive-macros/src/builder/recipe.rs:576:9 | 576 | / return Ok(RecipeAttributes { 577 | | base, 578 | | base_parameters, 579 | | name, 580 | | }); | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 576 ~ Ok(RecipeAttributes { 577 + base, 578 + base_parameters, 579 + name, 580 ~ }) | warning: use of `unwrap_or_else` to construct default value --> /home/user/1tmp/ncurses_things/cursive/cursive-macros/src/builder/recipe.rs:561:49 | 561 | let mut name = base_default_name(&base).unwrap_or_else(String::new); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default warning: this expression creates a reference which is immediately dereferenced by the compiler --> /home/user/1tmp/ncurses_things/cursive/cursive-core/src/views/dialog.rs:35:59 | 35 | if let Ok(string) = context.resolve::<String>(&config) { | ^^^^^^^ help: change this to: `config` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default warning: this expression creates a reference which is immediately dereferenced by the compiler --> /home/user/1tmp/ncurses_things/cursive/cursive-core/src/views/dialog.rs:43:56 | 43 | if let Ok(obj) = context.resolve::<Object>(&config) { | ^^^^^^^ help: change this to: `config` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Commits

Commits on Jun 6, 2024

fix select_test's suggestion on how to run it

show width size when not 1 or 2, on panic

make it assert_eq to work with --release too

typo: have -> has in test name

fix some warnings for: cargo clippy --all-features

fix some warnings for: cargo clippy --all-targets

fix: $ cargo clippy --all-targets --all-features