From 29e5422c3e599ec7ee0abb1638f21e30e7569ff7 Mon Sep 17 00:00:00 2001 From: h1alexbel Date: Mon, 30 Dec 2024 16:19:47 +0300 Subject: [PATCH 1/4] feat(#62): atom-with-phi lint --- .../eolang/lints/critical/atom-with-phi.xsl | 42 +++++++++++++++++++ .../eolang/motives/critical/atom-with-phi.md | 17 ++++++++ .../allows-atoms-without-phi.yaml | 29 +++++++++++++ .../atom-with-phi/catches-atom-with-phi.yaml | 30 +++++++++++++ 4 files changed, 118 insertions(+) create mode 100644 src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl create mode 100644 src/main/resources/org/eolang/motives/critical/atom-with-phi.md create mode 100644 src/test/resources/org/eolang/lints/packs/atom-with-phi/allows-atoms-without-phi.yaml create mode 100644 src/test/resources/org/eolang/lints/packs/atom-with-phi/catches-atom-with-phi.yaml diff --git a/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl b/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl new file mode 100644 index 00000000..35bb5987 --- /dev/null +++ b/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl @@ -0,0 +1,42 @@ + + + + + + + + + + + + + + + + critical + Atoms must not have '@' attribute " + + + diff --git a/src/main/resources/org/eolang/motives/critical/atom-with-phi.md b/src/main/resources/org/eolang/motives/critical/atom-with-phi.md new file mode 100644 index 00000000..674c291d --- /dev/null +++ b/src/main/resources/org/eolang/motives/critical/atom-with-phi.md @@ -0,0 +1,17 @@ +# Atom With `@` + +Atoms must not have `@` attribute. + +Incorrect: + +```eo +# Foo. +[@] > foo /number +``` + +Correct: + +```eo +# Foo. +[] > foo /number +``` diff --git a/src/test/resources/org/eolang/lints/packs/atom-with-phi/allows-atoms-without-phi.yaml b/src/test/resources/org/eolang/lints/packs/atom-with-phi/allows-atoms-without-phi.yaml new file mode 100644 index 00000000..61686b8a --- /dev/null +++ b/src/test/resources/org/eolang/lints/packs/atom-with-phi/allows-atoms-without-phi.yaml @@ -0,0 +1,29 @@ +# The MIT License (MIT) +# +# Copyright (c) 2016-2024 Objectionary.com +# +# Permission is hereby granted, free of charge, to any person obtaining a copy +# of this software and associated documentation files (the "Software"), to deal +# in the Software without restriction, including without limitation the rights +# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +# copies of the Software, and to permit persons to whom the Software is +# furnished to do so, subject to the following conditions: +# +# The above copyright notice and this permission notice shall be included +# in all copies or substantial portions of the Software. +# +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE +# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +# SOFTWARE. +--- +sheets: + - /org/eolang/lints/critical/atom-with-phi.xsl +asserts: + - /defects[count(defect[@severity='critical'])=0] +input: | + # No comments. + [] > foo /number diff --git a/src/test/resources/org/eolang/lints/packs/atom-with-phi/catches-atom-with-phi.yaml b/src/test/resources/org/eolang/lints/packs/atom-with-phi/catches-atom-with-phi.yaml new file mode 100644 index 00000000..d5f0a835 --- /dev/null +++ b/src/test/resources/org/eolang/lints/packs/atom-with-phi/catches-atom-with-phi.yaml @@ -0,0 +1,30 @@ +# The MIT License (MIT) +# +# Copyright (c) 2016-2024 Objectionary.com +# +# Permission is hereby granted, free of charge, to any person obtaining a copy +# of this software and associated documentation files (the "Software"), to deal +# in the Software without restriction, including without limitation the rights +# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +# copies of the Software, and to permit persons to whom the Software is +# furnished to do so, subject to the following conditions: +# +# The above copyright notice and this permission notice shall be included +# in all copies or substantial portions of the Software. +# +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +# FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE +# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +# SOFTWARE. +--- +sheets: + - /org/eolang/lints/critical/atom-with-phi.xsl +asserts: + - /defects[count(defect[@severity='critical'])=1] + - /defects/defect[@line='2'] +input: | + # No comments. + [@] > foo /number From 62eacc5b4dd27454861fb43fa667400fd1d1f1fa Mon Sep 17 00:00:00 2001 From: h1alexbel Date: Mon, 30 Dec 2024 21:16:20 +0300 Subject: [PATCH 2/4] feat(#62): simpler xpath, better message --- .../resources/org/eolang/lints/critical/atom-with-phi.xsl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl b/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl index 35bb5987..60f64b03 100644 --- a/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl +++ b/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl @@ -27,7 +27,7 @@ SOFTWARE. - + @@ -36,7 +36,7 @@ SOFTWARE. critical - Atoms must not have '@' attribute " + Atom must not have '@' attribute " From aa6ba2a8bf2dae49fcdba151d1a74d345e868230 Mon Sep 17 00:00:00 2001 From: h1alexbel Date: Mon, 30 Dec 2024 21:21:15 +0300 Subject: [PATCH 3/4] feat(#62): void --- src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl b/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl index 60f64b03..82c919a4 100644 --- a/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl +++ b/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl @@ -36,7 +36,7 @@ SOFTWARE. critical - Atom must not have '@' attribute " + Atoms must not have void '@' attribute " From 8db3eff2562761a721febfec383ca01bc7ce09bd Mon Sep 17 00:00:00 2001 From: h1alexbel Date: Mon, 30 Dec 2024 22:26:01 +0300 Subject: [PATCH 4/4] feat(#62): typo --- src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl b/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl index 82c919a4..2ca3a8f2 100644 --- a/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl +++ b/src/main/resources/org/eolang/lints/critical/atom-with-phi.xsl @@ -36,7 +36,7 @@ SOFTWARE. critical - Atoms must not have void '@' attribute " + Atoms must not have void '@' attribute