GH-6707: added extended message to h2o.init to help user get around version mismatch error [nocheck] #15596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mn-mikke
changed the title
wendycwong
force-pushed
the
wendy_gh_6707_verion_mismatch_guide_master
branch
from
08d5f35
to
adecbf0
Compare
wendycwong
force-pushed
the
wendy_gh_6707_verion_mismatch_guide_master
branch
2 times, most recently
from
fce55bf
to
a5310d0
Compare
…version mismatch error. GH-6707 : remove R unit test because test environment cannot generate the correct error. It will error out at packageVersion(h2o). Pointed out by Tomas Fryda, we source and run the code and do not install the h2o packate.
tomasfryda
reviewed
Aug 11, 2023
tomasfryda
approved these changes
Aug 11, 2023
wendycwong
force-pushed
the
wendy_gh_6707_verion_mismatch_guide_master
branch
from
a5310d0
to
e108c57
Compare
Mohit1345
pushed a commit
to Mohit1345/h2o-3
that referenced
this pull request
Aug 17, 2023
…und version mismatch error [nocheck] (h2oai#15596) * h2oaiGH-6707 : added extended message to h2o.init to help user get around version mismatch error. h2oaiGH-6707 : remove R unit test because test environment cannot generate the correct error. It will error out at packageVersion(h2o). Pointed out by Tomas Fryda, we source and run the code and do not install the h2o packate. * replace circumvent with avoid from Tomas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem in GH: #6707
Apart from getting an error message when the Java backend and the client Python/R versions do not match, the clients have no way to get around it if it is not important to use different backend and client software versions. I added the method to circumvent this error message by showing the user what to do. It is not recommended though.
I added two client tests to make sure the new error messages show up.