Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column wise tooltip for table #1792

Open
shamilh2o opened this issue Jan 11, 2023 · 6 comments · May be fixed by #2349
Open

Column wise tooltip for table #1792

shamilh2o opened this issue Jan 11, 2023 · 6 comments · May be fixed by #2349
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI

Comments

@shamilh2o
Copy link

Is your feature request related to a problem? Please describe

Need to give a description about the values in a particular column when hover on top of the column name.

Describe the solution you'd like

I would like to have a feature to show a tooltip for each column name instead of having a single tooltip for the entire table.
Something like shown below,
image

Describe alternatives you've considered

Tried to use the tooltip which already has for the entire table to convey the message. But that is not efficient when it come to the application.

Additional context

Discussion #1784

@shamilh2o shamilh2o added the feature Feature request label Jan 11, 2023
@mturoci mturoci added ui Related to UI good first issue Contributions welcome! labels Jan 11, 2023
@yy30537
Copy link

yy30537 commented Mar 31, 2023

Hi, I'm trying to work on this issue as a first time contributor. To my understanding, we want to be able to add an argument 'tooltip' when creating a column such as:

  page['example'] = ui.form_card(box='1 1 3 3', items=[
      ui.table(
          name='table',
          columns=[
              ui.table_column(name='name', label='Name'),
              ui.table_column(name='value', label='Value', tooltip="tooltip for column name value"),
          ], 
          rows=[
              ui.table_row(name='row1', cells=['item0', 0]),
              ui.table_row(name='row2', cells=['item1', 1]),
              ui.table_row(name='row3', cells=['item2', 2]),
          ],
          tooltip="tooltip for entire table"
      )
  ])

which should create a table like this:
Screenshot from 2023-03-31 16-17-29

Initially, I tried to edit an additional tooltip property into the table_column in ui.py and the interface TableColumn in the table.tsx so that the user can specify an argument; then change how the header is rendered in table.tsx; however I discovered that types.py is generated and I cannot modify h2o_wave.types.TableColumn. How should I approach this issue? Thanks in advance

FourLeavesTY added a commit to FourLeavesTY/wave that referenced this issue Apr 22, 2023
@mturoci
Copy link
Collaborator

mturoci commented Jun 26, 2023

Hey @yy30537, super sorry for the late reply, but Github didn't send me the notification.

As you correctly pointed out, types.py etc. are generated. You can generate them (along with bunch of other stuff) by running make generate in the root project. See our contributing guide to learn more.

@Gingaaa
Copy link

Gingaaa commented Aug 20, 2023

Hey I have worked on around 7-8 company based project, but never countribute to open source this is my first time can you assign me this task.

@mturoci
Copy link
Collaborator

mturoci commented Aug 21, 2023

Go ahead @Gingaaa. No assignment necessary :)

@vaiishnavii
Copy link

Hey! @mturoci I would like to work on this issue if nobody is working yet.

@mturoci
Copy link
Collaborator

mturoci commented May 23, 2024

Go ahead @vaiishnavii. No need to ask upfront :)

@nivzx nivzx linked a pull request Jun 10, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request good first issue Contributions welcome! ui Related to UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants