Add Warpwire URL support #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR: h5p/h5p-video#75 |
|
For testing, you can use this video URL: https://support.warpwire.com/w/CUgAAA/ |
|
The conflicts have been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warpwire is a video management and playback platform that is used mostly by educational institutions. It has been requested that we support H5P. To that end, we have added Warpwire URL detection and tested it on Moodle and Drupal 7.
Note that since we allow whitelabeled domains, it is not possible to test for Warpwire URLs by domain name patterns. The URL structure after the domain is consistent, albeit broad. If there is a better way to perform this test, I am open to changing the code.