HFP-4128 Fix re-creating state for user responses #69
Conversation
js/summary.js
Outdated
| @@ -179,9 +182,11 @@ H5P.Summary = (function ($, Question, XApiEventBuilder, StopWatch) { | |||
| that.dataBitMap[panelIndex] = this.dataBitMap[panelIndex] || []; | |||
| that.dataBitMap[panelIndex][id] = summaryIndex; | |||
|
|
|||
| emptyEntriesCount = that.dataBitMap[panelIndex].length - (that.dataBitMap[panelIndex].filter(function () { return true; })).length; | |||
There was a problem hiding this comment.
@otacke : Can you please explain this one? I.e: I don't understand what it does, since the filter callback function always returns true? Won't emptyEntriesCount always be zero? Independent of that, I would split this into several lines.
There was a problem hiding this comment.
@fnoks The that.dataBitMap[panelIndex] array can contain empty values, which are counted when using length, but here we need the number of actual values. filter will only work on real values, not on empty values, so the emptyEntriesCount will not always be zero but the count of the empty values.
I have added some verbosity ...
|
Can this fix be merged to the master? it is from the year 2022 @fnoks |
|
@otacke : Do you know if this issue has a Jira ticket? |
|
@fnoks Don't think so. But I can create one (manually ;-)). |
otacke
changed the title
As reported and discussed in h5p/moodle-mod_hvp#442, Summary does not re-create the previous state properly - the visual score is correct, but the score that
getScorereports is wrong.When merged in, this bug will be fixed: will re-create the
userResponsesvariable correctly, sogetScorereports the correct score.