Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HFP-4128 Fix re-creating state for user responses #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

HFP-4128 Fix re-creating state for user responses #69

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d840390
Fix re-creating state for user responses
otacke Mar 22, 2022
195ea2e
Add verbosity for non-obvious behavior
otacke Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions js/summary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,9 @@ H5P.Summary = (function ($, Question, XApiEventBuilder, StopWatch) {
summaries: []
};

// dataBitMap can contain empty entries as offset for previous panels
var emptyEntriesCount = 0;

for (var summaryIndex = 0; summaryIndex < that.summaries[panelIndex].summary.length; summaryIndex++) {
var isAnswer = (summaryIndex === 0);
that.answer[id] = isAnswer; // First claim is correct
Expand All @@ -179,9 +182,11 @@ H5P.Summary = (function ($, Question, XApiEventBuilder, StopWatch) {
that.dataBitMap[panelIndex] = this.dataBitMap[panelIndex] || [];
that.dataBitMap[panelIndex][id] = summaryIndex;

emptyEntriesCount = that.dataBitMap[panelIndex].length - (that.dataBitMap[panelIndex].filter(function () { return true; })).length;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@otacke : Can you please explain this one? I.e: I don't understand what it does, since the filter callback function always returns true? Won't emptyEntriesCount always be zero? Independent of that, I would split this into several lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fnoks The that.dataBitMap[panelIndex] array can contain empty values, which are counted when using length, but here we need the number of actual values. filter will only work on real values, not on empty values, so the emptyEntriesCount will not always be zero but the count of the empty values.

I have added some verbosity ...


// checks the answer and updates the user response array
if(that.answers[panelIndex] && (that.answers[panelIndex].indexOf(id) !== -1)){
this.storeUserResponse(panelIndex, summaryIndex);
this.storeUserResponse(panelIndex, emptyEntriesCount + summaryIndex);
}

// adds to elements
Expand All @@ -193,7 +198,7 @@ H5P.Summary = (function ($, Question, XApiEventBuilder, StopWatch) {

// if we have progressed passed this point, the success pattern must also be saved
if(panelIndex < that.progress){
this.storeUserResponse(panelIndex, 0);
this.storeUserResponse(panelIndex, emptyEntriesCount);
}

// Randomize elements
Expand Down