Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: add automatic linter to check config #28

Merged
merged 3 commits into from
Aug 19, 2024
Merged

lint: add automatic linter to check config #28

merged 3 commits into from
Aug 19, 2024

Conversation

div72
Copy link
Contributor

@div72 div72 commented Aug 16, 2024

No description provided.

@div72
build.nix: fix config
8f04e6e 
Updates the default value for the port and changes the WEBHOOK_URL to
not contain the api key as the config.py does it now.
@div72 div72 requested a review from furkansimsekli August 16, 2024 14:34
@div72 div72 self-assigned this Aug 16, 2024
@div72 div72 added bug Something isn't working enhancement New feature or request labels Aug 16, 2024
@div72 div72 force-pushed the fix-config branch 2 times, most recently from 9063476 to 8edb653 Compare August 16, 2024 14:40
@div72 div72 marked this pull request as ready for review August 16, 2024 14:40
furkansimsekli
furkansimsekli requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@furkansimsekli furkansimsekli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have nix installed in my computer rn, but if it's working then it's working. I'm sure you tested well enough.

Can you rename the lint-config.py to either config.py or lint_config.py?

@div72 div72 requested a review from furkansimsekli August 19, 2024 15:08
furkansimsekli
furkansimsekli approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@furkansimsekli furkansimsekli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@furkansimsekli furkansimsekli merged commit 481b187 into master Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkansimsekli furkansimsekli furkansimsekli approved these changes

Assignees

@div72 div72

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@div72 @furkansimsekli