Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: completed issue 4: create navbar component #27

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

jasmiineng
Copy link
Contributor

@jasmiineng jasmiineng commented Jan 29, 2025

Developer: Jasmine Ng

Closes #4

Pull Request Summary

Completed Issue 4: Create Navbar Component

Modifications

  • Added logo to public
  • Made logo on navbar navigate back to home
  • Added template for notification and profile

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

Screenshot 2025-01-28 at 11 10 44 PM

@aarav27 aarav27 self-requested a review January 30, 2025 07:32
Copy link
Collaborator

@aarav27 aarav27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this looks good! Thanks for having the comments for needing to change to an image later on.

@aarav27 aarav27 merged commit 082f5bc into develop Jan 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Navbar Component
2 participants