Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upload component and Client Upload Page #24 #44

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

sab115
Copy link
Contributor

@sab115 sab115 commented Feb 10, 2025

Developer: Sabrina Huang

Closes #24

Pull Request Summary

Implemented the DocumentUpload component and the ClientUpload page.
DocumentUpload component allows users to upload PDFs and other documents via drag-and-drop or file selection.
The client-upload page integrates this component and provides a placeholder for a client checklist.

Modifications

components/DocumentUpload.tsx:

  • Created the DocumentUpload component using react-drag-drop-files for document uploading.
  • Added file type restrictions and size limit (1GB).
  • Added UI elements for drag-and-drop interaction and file preview.
  • Displays selected file name for now

client-upload/page.tsx:

  • Created the client-upload page which incorporates the DocumentUpload component.
  • Added a checklist placeholder (for future use).
  • Included buttons (Delete, Download) that are currently disabled.

components/Navbar.tsx + components/Footer.tsx:

  • Adjusted the padding and height of the Navbar and Footer components to improve the page layout.

Testing Considerations

  • Ensure that the DocumentUpload component correctly handles file drag-and-drop and file selection for valid file types (PDF, JPEG, PNG, DOCX, DOC).
  • Verify the file size validation works (files above 1GB should trigger an error).
  • Confirm that the layout of the ClientUploadPage matches the design provided in Figma.
  • Test that the checklist placeholder renders correctly and the buttons are displayed, but remain disabled for now.
  • Test that the DocumentUpload component displays the correct selected file name.

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

Screenshot 2025-02-09 at 11 07 03 PM

@sab115 sab115 requested review from aarav27 and ktaschek February 10, 2025 07:09
Copy link
Collaborator

@aarav27 aarav27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job Sabrina, LGTM! Thanks for the detailed PR write up as well.

@aarav27 aarav27 merged commit 290b587 into develop Feb 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload component and Client Upload Page
2 participants