Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Background-Images With <Image> #156

Open
javalosr2004 opened this issue May 20, 2024 · 0 comments · May be fixed by #180
Open

Replacing Background-Images With <Image> #156

javalosr2004 opened this issue May 20, 2024 · 0 comments · May be fixed by #180
Assignees
Labels

Comments

@javalosr2004
Copy link
Collaborator

Description
Using background-image with out components has been causing a lot of performance issues and breaks with any special characters such as <image_name> (1).jpg.

Acceptance Criteria
Replaces all usage of background-image, with equivalent styling.

Steps:

  • Find all components that use background-image, if in vscode you can make use of find in files.
  • Replace these with , as this is cached. A good example would be Ella's page, /admin/events/[eventId]/edit.
  • If copying Ella's code doesn't work, try following: https://www.geeksforgeeks.org/how-to-fit-background-image-to-div-using-css/. Have it be a child of parent component that displays information of event.
@sgill33 sgill33 self-assigned this Jun 5, 2024
@sgill33 sgill33 linked a pull request Jun 10, 2024 that will close this issue
6 tasks
@sgill33 sgill33 linked a pull request Jun 10, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants