Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch protection on the main branch #212

Open
maxwofford opened this issue Dec 19, 2023 · 2 comments
Open

Branch protection on the main branch #212

maxwofford opened this issue Dec 19, 2023 · 2 comments

Comments

@maxwofford
Copy link
Member

Currently we don't have branch protection warning users they're merging in a change that breaks the build. I'd like to add branch protection to the main branch preventing merge unless CI passes. This wouldn't actually slow down development because merging into main (currently) just fails silently and leaves production on the previous commit. Branch protection can be overwritten, but requires an extra prompt to ensure the user knows they're merging in something that will fail to deploy.

@maxwofford
Copy link
Member Author

Once #234 is merged this would be good to add. Unfortunately this is just a repo setting, not a PR change. @leomcelroy, mind if I edit this in the settings?

@leomcelroy
Copy link
Contributor

Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants